JoinColony / colonyDapp

Colony dApp client
49 stars 19 forks source link

Voters on the winning side who didn't stake are unable to claim their reward #3955

Open arrenv opened 1 year ago

arrenv commented 1 year ago

Steps to reproduce

  1. Have at least three members in a Colony with reputation. No one should have over the voting threshold in reputation (default is 70%),
  2. Disable the Reputation monitor so that it does not fast forward you through the Motion on each transaction - http://localhost:3001/reputation/monitor/toggle
  3. Create a Motion
  4. Fully stake with one member and fully object with the other member on the Motion to get to a Vote.
  5. The third member should not stake at all but make sure they are on the winning side.
  6. Vote on the Motion with all three members.
  7. Get to the claiming phase.
  8. The third member who didn't stake but did vote should be able to claim a voting reward, but there is no option to.

You may need to check if there is actually a way to get this information from the SubGraph or via the client.

Expected behaviour

Actual behaviour

3ab72445-83b7-4500-b50b-b615013ca201

chinins commented 1 year ago

@arrenv, I've investigated and then also talked to Alex and this is not a bug. The claim button is for claiming stakes ONLY! The vote reward is claimed when a user reveals his vote. So this par of the process

Screenshot 2022-10-11 at 13 54 44

Maybe we should add some info somewhere that clarifies that to avoid confusion int he future?