search

JoinColony / colonyNetwork

Colony Network smart contracts
https://colony.io/
GNU General Public License v3.0
438 stars 106 forks source link

Streaming payments only support a single stream #1250

Closed area closed 2 months ago

area commented 3 months ago

NB Based on maint/pnpm.

Multiple streams in a single streaming payment are no longer desired on the frontend, so taking the opportunity to simplify the contracts. This will also allow accurate tracking of the number of pending payments, allowing the 'prevent uninstall if pending payments' feature.

I've taken advantage of finishUpgrade to make sure someone can't upgrade from v4 to v5, which we are declaring is impossible due to the storage layout changes.

area commented 2 months ago

NB Now based on #1262

kronosapiens commented 2 months ago

What's with all the storage file changes? Does the PR need a rebase? Also is this ready to go off draft?

area commented 2 months ago

It does not need rebasing. The one change in .storage-layouts-normalized is expected - we have changed a struct, and removed a mapping. The changes in .storage-layouts to other files are because of changes to the code since the last time a storage slot was changed, and so AST IDs have changed in the rest of the compiled contracts. #1258 attempted to go through this in more detail, but we can have a call to make sure we both know what's going on, if you'd prefer.