JoinColony / colonyNetwork

Colony Network smart contracts
https://colony.io/
GNU General Public License v3.0
438 stars 106 forks source link

Prevent StreamingPayment uninstallation if pending streams remain #1251

Closed area closed 3 weeks ago

area commented 3 months ago

The main feature here is to prevent uninstallation of the extension in the event that there are some streaming payments unclaimed. It also:

area commented 1 month ago

You mention that changing the interval is necessary to avoid rounding errors, but realistically what are the errors we're talking about? A few wei? I would be in favor of going the opposite direction and hard-coding the interval as 24 hours. We can provide a UI which converts different intervals (hour, week month, etc) if needed.

If tokens don't have, or have set decimals() to 0, then 'A few wei' could easily have significant value.

In terms of a hard-coded interval, even ignore editing existing streams: if we had it at 24 hours, we couldn't e.g. pay out 1 token that had decimals() as 0 every 16 hours.