JoinColony / colonyNetwork

Colony Network smart contracts
https://colony.io/
GNU General Public License v3.0
438 stars 106 forks source link

Bump hardhat to 2.22 #1254

Closed kronosapiens closed 1 month ago

kronosapiens commented 3 months ago

Closes #1228

Main

Misc

kronosapiens commented 3 months ago

Thinking about this more, I'm not sure if there's much benefit to including uninstall as part of the extension interface in general. We can still support uninstallExtension at the network-level, but the implementation should be changed to:

  1. Remove all permissions from the extension in the colony
  2. Delete the extension from the installations mapping

I say this because we already have a deprecate function which does all of the restricting that we would add to an uninstall function, which makes me think that an uninstall which locks all functions would be mostly redundant.

If anything, the uninstall function on the extension should perform checks to see if we are ready to uninstall the extension via the network. I'm thinking of streaming payments here, where uninstall would simply error if there were unclaimed funds.

UPDATE: after discussing with @area we will delete both resolver and colony on "uninstall".