Closed kronosapiens closed 1 month ago
Thinking about this more, I'm not sure if there's much benefit to including uninstall
as part of the extension interface in general. We can still support uninstallExtension
at the network-level, but the implementation should be changed to:
installations
mappingI say this because we already have a deprecate
function which does all of the restricting that we would add to an uninstall
function, which makes me think that an uninstall
which locks all functions would be mostly redundant.
If anything, the uninstall
function on the extension should perform checks to see if we are ready to uninstall the extension via the network. I'm thinking of streaming payments here, where uninstall
would simply error if there were unclaimed funds.
UPDATE: after discussing with @area we will delete both resolver
and colony
on "uninstall".
Closes #1228
Main
cancun
hardforkselfdestruct
and update uninstall behavior for extensionsColonyExtension.sol
base class and remove boilerplate from extension contractsMisc
reputation-test-non-gnosis
Circle job to reduce total build timesgetMetatransactionNonce
consistent among affected contracts