search

JoinColony / colonyNetwork

Colony Network smart contracts
https://colony.io/
GNU General Public License v3.0
438 stars 106 forks source link

Use overrides to fix wrong dependency URLs #1261

Closed chmanie closed 2 months ago

chmanie commented 2 months ago

eth-sig-util in an old version (1.4.2) uses an ssh URL for a dependency in its package.json which causes pnpm install to fail.

Before, this was fixed using a change in git config, but that doesn't seem to work in all environments (e.g. if users do not have ssh setup, it will fail for them without the aforementioned git config, or, as experienced by me, on Github actions).

This now sets the http git URL to the commit that was referenced in the SSH link in the pnpm overrides.

chmanie commented 2 months ago

Thank you for the quick turnaround!