JoinColony / colonyNetwork

Colony Network smart contracts
https://colony.io/
GNU General Public License v3.0
438 stars 106 forks source link

Introduce hardhat_setStorageAt #1270

Closed kronosapiens closed 1 month ago

kronosapiens commented 2 months ago

Replace the custom storage editing via ContractEditing with calls to hardhat_setStorageAt. We are still dependent on ContractEditing functionality in the Ganache-based tests, as the special opcode is not available.

area commented 1 month ago

I've updated the provider to be more in line with what I wanted. Specifically, I do not want helpers going forward to make assumptions about the network the contract is on, and so by using the provider on the provided contract object, we know we're always setting the storage slot on the right chain.

kronosapiens commented 1 month ago

@area your changes look good to me