search

JoinColony / purser

Interact with Ethereum wallets easily
https://joincolony.github.io/purser
MIT License
84 stars 21 forks source link

Conflict: trezor can not be installed after metamask #224

Open olegabr opened 5 years ago

olegabr commented 5 years ago 
npm i @colony/purser-metamask
npm i @colony/purser-trezor
npm ERR! path /tmp/test/node_modules/websocket
npm ERR! code EISGIT
npm ERR! git /tmp/test/node_modules/websocket: Appears to be a git repo or submodule.
npm ERR! git     /tmp/test/node_modules/websocket
npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/olegabr/.npm/_logs/2019-04-21T09_57_58_195Z-debug.log
rdig commented 5 years ago

I don't remember experiencing this, but I'll try to replicate it locally nonetheless.

Thanks for reporting it.

DuncanBetts commented 5 years ago

I get this same error when running npm install repeatedly with Nexchange's Open Source Frontend, and just submitted a PR to the same, with a workaround - is there a better solution? Apologies if you would have preferred a separate Issue but my issue is almost identical (except I get the error regardless of what I try to install).

rdig commented 5 years ago

As I've mentioned last time I've tried this I couldn't replicate it.

But I guess enough time has passed since then, and a bunch of purser versions were released in the mean time, so It's time to check again :)

There should be better solution for this, that you to have to work around it in your repo, but I'll have to investigate.

At the very least, I can integrate your fix directly in this library.