Open JamesLefrere opened 5 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
This PR makes some changes to the
purser-ledger
andpurser-trezor
packages (necessitating some small changes topurser-core
) such that the seeded signature values for the transaction to be signed (i.e.r
,s
andv
) are not included. This is becauseethereumjs-tx
makes validations for EIP-155 that read these values (if present) and compare them with the chain ID, which was leading to validation errors for mainnet transactions.Changes
r
,s
andv
values from the unsigned transaction for Ledger and TrezorbigNumberToHexString
util