JoinColony / purser

Interact with Ethereum wallets easily
https://joincolony.github.io/purser
MIT License
84 stars 21 forks source link

Fix Ledger/Trezor transaction signing #271

Open JamesLefrere opened 5 years ago

JamesLefrere commented 5 years ago

This PR makes some changes to the purser-ledger and purser-trezor packages (necessitating some small changes to purser-core) such that the seeded signature values for the transaction to be signed (i.e. r, s and v) are not included. This is because ethereumjs-tx makes validations for EIP-155 that read these values (if present) and compare them with the chain ID, which was leading to validation errors for mainnet transactions.

Changes

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.