JoinColony / purser

Interact with Ethereum wallets easily
https://joincolony.github.io/purser
MIT License
84 stars 21 forks source link

Support MetaMask mobile #296

Closed filmerjarred closed 4 years ago

filmerjarred commented 4 years ago

Fix for https://github.com/JoinColony/purser/issues/288 to support the new ethereum provider api

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

filmerjarred commented 4 years ago

Old 2020-03-18 19_21_56-DevTools - colony io_connect

New 2020-03-18 19_19_01-DevTools - 81f35b7c ngrok io_

chmanie commented 4 years ago

Hey @BrighTide! That looks really great! Would you do me a favour and rebase your PR on the current master? We'll then proceed on testing it

chmanie commented 4 years ago

Oh, sorry to be picky here but could you please rebase instead of merging upstream? We like to keep our git trees tidy :)

filmerjarred commented 4 years ago

Ha, don't worry I appreciate keeping things tidy. Just having a little trouble navigating rebasing from a fork. Good chance to read up on my gitfu

chmanie commented 4 years ago

I think it might even make sense to squash all your commits into one.

filmerjarred commented 4 years ago

Ok, went through the rebase and git log seems to think my four commits are the most recent so I think we're good?

filmerjarred commented 4 years ago

I think it might even make sense to squash all your commits into one.

Ah sorry just saw this, still want me to squash them?

chmanie commented 4 years ago

Ah, no, it's fine. Maybe just squash the commits in which the package.json was changed (48a0644) with the yarn.lock changes (fc223aa) (it's always good to have these together).

chmanie commented 4 years ago

Hey @BrighTide, would you mind posting your address here, that you are using in the colony so that we can release your bounty once we've merged this? Cheers!

filmerjarred commented 4 years ago

No worries :) "0x5D748885F040d45439Bfe4e463b271E4180937D1"

chmanie commented 4 years ago

Fantastic! Merging and releasing the payout!