Closed filmerjarred closed 4 years ago
Old
New
Hey @BrighTide! That looks really great! Would you do me a favour and rebase your PR on the current master? We'll then proceed on testing it
Oh, sorry to be picky here but could you please rebase instead of merging upstream? We like to keep our git trees tidy :)
Ha, don't worry I appreciate keeping things tidy. Just having a little trouble navigating rebasing from a fork. Good chance to read up on my gitfu
I think it might even make sense to squash all your commits into one.
Ok, went through the rebase and git log seems to think my four commits are the most recent so I think we're good?
I think it might even make sense to squash all your commits into one.
Ah sorry just saw this, still want me to squash them?
Ah, no, it's fine. Maybe just squash the commits in which the package.json
was changed (48a0644
) with the yarn.lock
changes (fc223aa
) (it's always good to have these together).
Hey @BrighTide, would you mind posting your address here, that you are using in the colony so that we can release your bounty once we've merged this? Cheers!
No worries :) "0x5D748885F040d45439Bfe4e463b271E4180937D1"
Fantastic! Merging and releasing the payout!
Fix for https://github.com/JoinColony/purser/issues/288 to support the new ethereum provider api
pursuer-metamask was failing on mobile
Mobile version of metamask was using an etherum provider with a new unsupported api
Re-implemented code to get the address and listen for account changes to respect new api whilst still being backwards compatible.
Added tests
Adjusted npm scripts to be windows compatible
The test environment for mobile can be found here https://github.com/BrighTide/purser/tree/69b9cfb685cc8c0dc3ad217ffb9c80653d61277f/metmask-mobile-test