search

JoinColony / solcover

Code coverage for solidity
MIT License
64 stars 8 forks source link

Refactor and lint #49

Closed area closed 7 years ago

area commented 7 years ago

Moved injector and parse into their own files. I don't think I'm going to merge this just yet, I think there are some more improvements that can be made, but I'm pretty sure this is all going in the right direction!

codecov-io commented 7 years ago

Current coverage is 98.28% (diff: 97.66%)

Merging #49 into master will increase coverage by 0.21%

@@             master        #49   diff @@
==========================================
  Files             3          6     +3   
  Lines           311        291    -20   
  Methods          74         47    -27   
  Messages          0          0          
  Branches         54         39    -15   
==========================================
- Hits            305        286    -19   
+ Misses            6          5     -1   
  Partials          0          0

Powered by Codecov. Last update 4a25ec6...bc6dd8c

cgewecke commented 7 years ago

👍 👍 👍

area commented 7 years ago

This is probably enough to be worth merging and doing any more on another branch.

cgewecke commented 7 years ago

This looks really good to me - it's a dramatic increase in clarity. And CI is green. It's great.