JoinColony / solcover

Code coverage for solidity
MIT License
64 stars 8 forks source link

Fix Zeppelin tests #52

Closed area closed 7 years ago

area commented 7 years ago

I've done two things here, one more controversial than the other:

codecov-io commented 7 years ago

Current coverage is 98.28% (diff: 100%)

Merging #52 into master will not change coverage

@@             master        #52   diff @@
==========================================
  Files             6          6          
  Lines           291        291          
  Methods          47         47          
  Messages          0          0          
  Branches         39         39          
==========================================
  Hits            286        286          
  Misses            5          5          
  Partials          0          0          

Powered by Codecov. Last update 93a7f41...a1a4aeb

cgewecke commented 7 years ago

Oh no, that's really bad that those tests were doing nothing. I'm into using zepellin as a baseline. They actively work on the contracts and cover a lot of ground. It would be cool to be able to swap the zepellin source out every three months or so and run against the new version and see if everything's good.

area commented 7 years ago

Ultimately I'd like to remove them, but they're certainly a valuable canary in the coalmine for now!

cgewecke commented 7 years ago

Well, now they are. Before they were like a plastic canary floating in a canal somewhere.