search

JoinMarket-Org / joinmarket-clientserver

Bitcoin CoinJoin implementation with incentive structure to convince people to take part
GNU General Public License v3.0
700 stars 173 forks source link

Discuss / test combining IRC peer discovery with direct onion messaging #1449

Open kristapsk opened 1 year ago

kristapsk commented 1 year ago

I just updated the title of this issue to make it more clear.

It's not about replacing the onion messages between makers and takers, it's only about adding an alternative to the existing IRC channels or directory nodes.

Actually IRC also could be combined with direct onion messaging. Taker uses IRC for peer discovery and then asks also which of them support direct onion messaging. And then for these peers would connect directly instead of using IRC PRIVMSG for communication. Kinda like IRC DCC.

Originally posted by @kristapsk in https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1446#issuecomment-1418019231

Likely should not be too hard to implement, as we already have both IRC and direct onion messaging code. But question is it worth doing.

Reality is that currently DarkScience IRC seems to be more stable than dnodes people are running.

PulpCattel commented 1 year ago

I proposed something similar back in the days, so I'm all for it.

Reality is that currently DarkScience IRC seems to be more stable than dnodes people are running.

Hopefully this will get fixed at some point. I think we all agree to phase out IRC eventually.

kristapsk commented 1 year ago

If we combine IRC peer discovery with direct onion messaging, there are no actual benefits on phasing out IRC, apart from code maintenance. We can have multiple peer discovery mechanisms, it does not hurt.

PulpCattel commented 1 year ago

If we combine IRC peer discovery with direct onion messaging, there are no actual benefits on phasing out IRC, apart from code maintenance.

The way I see it, eventually we won't need to use IRC for peer discovery because no one will be using IRC to begin with. But I get your point and surely there is no rush.

kristapsk commented 1 month ago

This comment reminded me of this idea.