JoinMarket-Org / joinmarket-clientserver

Bitcoin CoinJoin implementation with incentive structure to convince people to take part
GNU General Public License v3.0
699 stars 173 forks source link

signpsbt do not allow to sign an utxo already spent in an unconfirmed transaction #1679

Open divoc91ab opened 4 months ago

divoc91ab commented 4 months ago

wallet-tool.py signpsbt do not allow the signing of a transaction spending an utxo spent in another unconfirmed transaction.

The psbt is correctly parsed but The PSBT is not yet fully signed, we signed: 0 inputs. is the result of the script.

Version 0.9.11 (It is the first issue that I open, so if it is missing any detail let me know)

kristapsk commented 3 months ago

According to code, signing PSBT that double spends wallet input in a new transaction that conflicts with another unconfirmed transaction from mempool should work ("utxos that we've stopped tracking"). Probably there is some bug or edge case.

https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/5bfa08c6f558458c9a93e8095ce9dc1b62412838/src/jmclient/wallet.py#L1559-L1577