search

JoinMarket-Org / joinmarket-clientserver

Bitcoin CoinJoin implementation with incentive structure to convince people to take part
GNU General Public License v3.0
699 stars 173 forks source link

Fixed direct-send RPC-API to accept list of UTXOs #1713

Open amitx13 opened 3 weeks ago

amitx13 commented 3 weeks ago

This PR fixes #1712 and addresses https://github.com/joinmarket-webui/jam/issues/772 Changes Made:

  1. Updated the direct-send API to accept a list of UTXOs specified by the user.
  2. Implemented backend logic to handle the selection of these UTXOs for the transaction.
  3. Added necessary validation checks to ensure the specified UTXOs are part of the user's wallet and are unfrozen.
amitx13 commented 3 weeks ago

Thank you for the feedback. I will ensure the RPC-API maintains backwards compatibility and update the documentation as well.

amitx13 commented 3 weeks ago

Hey @kristapsk I am done with the requested changes. Could you please take a look when you have a moment 🙏

amitx13 commented 2 weeks ago

Hey @kristapsk if you have a moment, could you please take a look at docs/api/wallet-rpc.yaml I tried everything from my side but still, OpenAPI Diff keeps failing. It will be a great help for me as well as for JAM and JoinMarket users

kristapsk commented 2 weeks ago

Hey @kristapsk if you have a moment, could you please take a look at docs/api/wallet-rpc.yaml I tried everything from my side but still, OpenAPI Diff keeps failing. It will be a great help for me as well as for JAM and JoinMarket users

I'm quite busy with other stuff currently, but will try to take a look at some point, if you will not be able to solve that yourself.