search

JoinMarket-Org / joinmarket-clientserver

Bitcoin CoinJoin implementation with incentive structure to convince people to take part
GNU General Public License v3.0
713 stars 175 forks source link

contradiction between docs and --help output #741

Closed dooglus closed 3 years ago

dooglus commented 3 years ago

In v0.8.0.

https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/SOURCING-COMMITMENTS.md says:

Note that whatever utxo you add has to have a scriptPubKey of the same type as those of your current wallet (currently either nested or native segwit)

But $ python add-utxo.py --help tells me:

Also note this ONLY works for standard (p2pkh or p2sh-p2wpkh) utxos.

So does it work for native segwit utxos or not? Those would be p2wpkh wouldn't they, a type not listed by the --help output.

AdamISZ commented 3 years ago

Yes, thanks for the spot. Added fix in #747

dooglus commented 3 years ago

I'm not sure about that fix. The .md file still says "currently either nested or native segwit" whereas the --help output now lists 3 types of utxo, including p2pkh which the .md file doesn't mention.

kristapsk commented 3 years ago

Probably everything p2pkh related should be removed from add-utxo.py, as there is no support for p2pkh coinjoins in JM-CS currently anyway.

AdamISZ commented 3 years ago

Correct, that's a mistake on my part.

AdamISZ commented 3 years ago

Yes, double checked, as per the code in Maker, you can only use specifically utxos of the same flavor that the maker's wallet is, so there is basically zero way of using add-utxo with p2pkh utxos now, unless someone is setting up a customized pit somewhere, which is none of our business. So fixing this in #747 .