Open eragmus opened 9 years ago
chris-belcher
commented
9 years ago Integration with wallets generally requires co-operation with developers. Electrum is possible because Electrum plugins can be written. Bitcoin Core is possible because of the new flag -walletbroadcast=0 in 0.11
I don't know about Breadwallet, I've never used it or researched it.
eragmus
commented
9 years ago Okay, so it would depend on breadwallet's interest or lack thereof. BTW, breadwallet is likely the most popular wallet for iOS. This is why I mentioned it. Gaining the support of breadwallet should be a boon for JoinMarket liquidity (and hence overall viability of CoinJoin).
chris-belcher
commented
9 years ago I completely agree that having wallet integrating is a good thing.
From what I can tell, breadwallet does not have a plugin mechanism or any way I can see to integrate JoinMarket. So we'll need to ask the developers for their co-operation.
I'm hoping that once Bitcoin Core and Electrum integration are done, developers of other applications will want it for their wallets.
eragmus
commented
9 years ago Sounds good to me :). Let's hope Maxwell's renewed privacy push for Core (https://github.com/bitcoin/bitcoin/issues/6568) is fruitful.
eragmus
commented
9 years ago FYI, breadwallet's lead developer/founder said this about JoinMarket:
"once this market is up and running and has a reasonably deep liquid pool of join offers at very low competitive prices, then we might consider spending engineering resources implementing."
There is already a semi-decent supply in the market, according to the order book. When integrations with Electrum and/or Bitcoin Core are complete, then demand should increase. Once demand increases, then supply should also further increase, as word spreads that one could earn interest on their bitcoins in an almost-risk-free manner. It sounds like it would be a virtuous cycle and quite inevitable.
Have you gotten this project reviewed by Greg Maxwell? Privacy technologies are his field, so I'd welcome his expert input on the matter. Maybe he can refine the project and improve it even further.
Great system, btw. Good luck.
chris-belcher
commented
9 years ago That's good.
I've had a few chats with gmaxwell about the idea before I started writing it. I don't think he's looked in detail at the code but he's aware of it.
BTW apparently this wallet also intends to integrate JoinMarket http://samouraiwallet.com/alpha.html
CoinJoin Support Build in support for CoinJoin by integrating with JoinMarket
eragmus
commented
9 years ago Good to hear about gmaxwell.
And Samourai integration seems hopeful, too! Since Alpha 3 has a November 2015 targeted release, it indicates they'll be working on it in the upcoming 3 months.
eragmus
commented
9 years ago Hello, I noticed Colu colored coins capability has recently been integrated as a plugin for Bitpay's Copay wallet:
http://insidebitcoins.com/news/exclusive-interview-colu-releases-plugin-for-copay/34686
I mention it because maybe it will be easier and/or more fruitful to try to first include JoinMarket support as a Copay plugin instead of an Electrum plugin. Benefits? According to the link:
Why the Copay wallet? Was there a specific reason they opted to make a plugin for Bitpay’s wallet?
Copay wallet was an good choice for us – it’s a well adopted and fully open source wallet, with a very good UI and it’s multi-platform. We were also happy to find a lot of cooperation from Bitpay’s side. I think that this model of building add-ons or “apps within apps” is very interesting and definitely hope to see more companies explore this method because it allows companies to use established open source wallet with a good user base instead of starting from scratch.
Basically, Copay is... open source, HD, multisig, multiplatform (windows, mac, linux, chrome extension, iOS, android, windows phone) which means potentially more secure JoinMarket funds by allowing storage on a malware resistant encrypted device like iPhone, multi-wallet support, imminent Ledger hardware wallet support, testnet support, open source BitCore server, well tested (used by Bitpay as their main business wallet), etc.
Overall, it seems like a potentially superior platform to focus initial release efforts on than Electrum.
eordano
commented
9 years ago I don't think Copay is suitable for JoinMarket. It went through an architecture redesign around March and it now requires a server to run. This server will log all the addresses for a user or set of users, which is not very privacy friendly. You can run your own "copay wallet service" (https://github.com/bitpay/bitcore-wallet-service) -- but using Copay wouldn't be secure by default.
On the other hand, if Copay can be modified to start being a SPV wallet, it could work. There's already a Javascript SPV wallet implementation that runs on Chrome: https://github.com/throughnothing/BitcoinSPVCrx
eragmus
commented
9 years ago Well that's disappointing to realize, I guess I missed that change. They need to be lobbied to switch to SPV. I can't imagine why they rely on a server.
chris-belcher
commented
9 years ago Even though Copay's server will know all your addresses (like an Electrum server) it still might be worth integrating JoinMarket. CoinJoin stops the entire world trivially linking together addresses on the blockchain, so even if someone uses JoinMarket with Copay they might get an improvement in privacy.
In my mind the first wallet integrated will be Bitcoin-QT. It's the easiest one to do and it sets a good example for privacy.
chris-belcher
commented
9 years ago For reference, the conversation with Breadwallet https://github.com/voisine/breadwallet/issues/178#issuecomment-136427888
Later we should contact Bither wallet too.
I'm sure this has been discussed before, but for the purpose of clarity, is it theoretically possible to integrate JoinMarket into all major wallets for the purpose of increasing liquidity and opportunity for CoinJoins, and hence improve the "usability issue of CoinJoin"?
More specifically, I know an Electrum integration is being envisioned. What if breadwallet was also integrated? Could the Electrum integration be interoperable with the breadwallet integration, so that users of both wallets may CoinJoin with one another via JoinMarket's implementation (that provides seemingly a monetary incentive besides the inherent privacy incentive)?