Add reverse trust action in proposals and referendums - Githubissues

JoinSEEDS / seeds-smart-contracts

Smart contracts for SEEDS - A Regenerative Civilization Building Game.

https://docs.google.com/document/d/1C4w9Ol8VGabCIcQDVPDrwcTRoJXBqhrb7VjslwQbUGU/edit#heading=h.6f4sxygso816

MIT License

20 stars 6 forks source link

Add reverse trust action in proposals and referendums #369

Closed n13 closed 3 years ago

n13 commented 3 years ago

The current reverse trust uses the "against" action - I think that has some bugs / unintended consequences.

it's sensitive to the number in "against" - it should reverse the originally cast number, so if it was favour 5, it should now be against 5 (same amount)
It's using up the user's votes - example if they voted 99 points for the proposal, they now lose 99 votes from their current cycle

Spec

Add reversetrust(user, prop_id) action
Remove reverse trust code from "against" - this should make the code cleaner as well

Reverse trust

Changes the user's "favour" vote to an "against" vote on a proposal in eval stage
If they did not vote favour, error
if proposal not in eval state, error
Does not use up any votes the user has for the current cycle

n13 commented 3 years ago

Note: depending on how the refactor is doing, we may just put this there...