search

JoinSEEDS / seeds_light_wallet

http://www.joinseeds.earth/
MIT License
45 stars 23 forks source link

Waiting Wheel on import account #1040

Open n13 opened 3 years ago

n13 commented 3 years ago

Describe the bug If we fail to retrieve the Seeds account of an existing Telos account, the waiting wheel spins forever.

To Reproduce Steps to reproduce the behavior:

  1. Import key
  2. Simulate a failure of get account
  3. wait

Current behavior Loader spins forever

Expected behavior Error message and "try again" button which restarts the process.

This happens only when we

Would also be nice to distinguish between a failed load of a Seeds account and an empty result - that's in ProfileRepository

Screenshots

Additional context ProfileRepository also contains an error since it throws an exception if noSeeds account is found, in this line

          return ProfileModel.fromJson(body['rows'][0]);

Crashes if rows is empty - meaning "not a seeds account"

Should return result.failure with error message that the user does not exist.

n13 commented 3 years ago

Assign to Jason to consider the UX -

There's two error cases - one is the request to load the account has failed - we handle this failure (network failure)

Other one is, we try to get the seeds user for an account, but they are not a Seeds user. Example account "funds.seeds"

RaulUrtecho commented 2 years ago

@n13 Is this bug still reproducible?