search

JoinSEEDS / seeds_light_wallet

http://www.joinseeds.earth/
MIT License
45 stars 23 forks source link

ESR fix [1/2]: Support multiple actions #1259

Closed n13 closed 2 years ago

n13 commented 3 years ago

Why

Currently, the light wallet only processes the first in the list of actions in an ESR (EOSIO Signing Request)

It needs to process all actions

The p2p app uses some transactions that are multiple actions, we need to support them

Spec

This ticket is for non-UX work - pass around a list of Actions, rather than a single action in the form of name, contract, parameters.

Implementation

There's two different Action objects, on in ESR and one in the eosdart library.

Create a ESR Data object that contains the data. The name Action also conflicts with a few different dart "Action" objects.

Pass around the ESR Data object.

n13 commented 3 years ago

I am thinking - I can easily do this, have already almost finished a PR for it, when it comes to the data structures and sending the EOSIO action, state, bloc and so on.

But would like some help on the user interface, showing a list of actions instead of just 1 action

Given the amount of changes, should be 2 PRs anyway