[2/2] Citizenship upgrade fixes

n13 commented 2 years ago

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

When upgrading to citizen there were many bugs and graphics errors.

The graphic and state errors appeared when upgrading from resident to citizen -> the citizenship card then disappears.

I traced the cause of these issues to the usage of a fixed ListView component - that component does not like when its contents change size.

✅ Checklist

[x] I have tested all my changes.

🕵️‍♂️ Notes for Code Reviewer

isVisitor value in settings - was not being used, removed.

isCitizen value in settings

Reducing usage of the isCitizen value stored in settings, since this value is a server value. Storing it client side leads to bugs.
It's still used in the vote module as a sort of cached value - it's OK to use there. Does no harm.

Fixed list view issues

A fixed list view shows errors when component sizes inside the fixed list view change. So adding or removing the citizen card on the profile view caused graphics errors. The components inside the list view would change size, but the list view would not update.

Bugfix:

Added fixed size to shimmer component so whether it's shimmering or not, it has the same height.
Moved variable length list view elements to builder, out of fixed list view. Not sure there's a more elegant method?!