chuck-h
commented
2 years ago New token & card scheme sounds good. As noted above, UI to set tokens individually as visible/not is needed; long list might be handled like a mobile app contacts list. Perhaps could be accessed thru card's ... menu. That ... menu might also expose some of the other token JSON fields (e.g. project website).
Do we need to be concerned about the order cards appear on the carousel? With PR#1880 it will be the order they were added to the tmastr.seeds contract.
Possible enhancement: allow groups of tokens to be made visible/not with one click. Groups could be user-defined (e.g. for different use contexts). Systemwide groups & classifications could be managed thru tokensmaster contract, ref. https://discord.com/channels/722537361480613950/736193477397708831/987395318188478484 on "token labelling".
Not too relevant, but interesting: if the token population explosion comes from Rainbow contract, loading all balances can be pretty efficient. You can get all the Rainbow balances for your account in one api call
n13
Is your feature request related to a problem? Please describe. Moving from hard coded tokens to master token contract, and potentially 100s of tokens in the ecosystem.
Our current Token List implementation is nice, but doesn't work for more than maybe a dozen tokens.
So we have to change as follows
Current Token management on wallet UI
Main screen loads balances for ALL tokens - if any of them has balance > 0, they show in the cards. If they showed in the cards before, they also show in the cards even if balance is 0 - ie, if I have 1 HYPHA, and I send the 1 HYPHA to someone, then I still have a card with 0 HYPHA
Upside: No token management for user Downside: Does not scale to 100s of potential tokens since balances are loaded for every single token every time we refresh.
Describe the solution you'd like A clear and concise description of what you want to happen.
New Token Management
There's a list of always-showing tokens - currently just SEEDS
We may populate the list looking at a user's recent 100 transactions and adding any active tokens to their initial default list.
Settings contains a list of all available tokens, with a switch to turn them on and off
Users need to go to settings to enable tokens
Each user then has a whitelist of tokens, stored on firebase, and these are the tokens that are on the main screen.
We could also store them on a wallet contract and use that as a backend. We only need to store IDs.
Token Cards Change
Each token card loads balance when it appears on screen.
The system never loads all token balances by itself.
The cards are responsible for loading balances, and they only do so when showing.
This way a user can select 100s of tokens as their cards, and we don't overwhelm the network connection - we only load them as needed, and as they are visible.
This is a standard way of handling indefinite lists in mobile apps; the only reason we're not doing it now is that, due to our system of checking all balances, we already have to load all balances.
A token card may have a ... menu to quickly remove token cards from the list