JoinSEEDS / seeds_light_wallet

http://www.joinseeds.earth/

MIT License

42 stars 22 forks source link

Allow transfer of unfamiliar tokens (1922) #1930

Closed chuck-h closed 1 year ago

chuck-h commented 1 year ago

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

1922

✅ Checklist

[ x] Github issue details are up to date for people to QA.
[ x] I have tested all my changes.

🕵️‍♂️ Notes for Code Reviewer

Technical explanations to help your peers review your work - including environments, credentials, etc.

🙈 Screenshots

For all UI changes

description 1	description 2
img1	img2

👯‍♀️ Paired with

@github-handle or "nobody" if you did not pair.

chuck-h commented 1 year ago

abandoning this PR; massive lint checks to resolve.

n13 commented 1 year ago

I think the "isTransfer" flag there should check for "familiar tokens" as well as contract and action.

Then, we treat all familiar transfers as transfer, but unfamiliar tokens will still work, they will just appear like a normal unspecific transaction.