search

JoinSEEDS / seeds_light_wallet

http://www.joinseeds.earth/
MIT License
42 stars 22 forks source link

fix eos serialize/deserialize for bool type #1934

Closed chuck-h closed 1 year ago

chuck-h commented 2 years ago

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

A bug in eosdart incorrectly deserializes a bool type into type int. If a transaction is deserialized (e.g. from QR or esr code) then reserialized, it will become badly formed. This is a problem when the LW is used as a general purpose signing wallet. Update: there's a bug in the bool-type serializer as well.

✅ Checklist

🕵️‍♂️ Notes for Code Reviewer

I am aware that this PR generates a lot of linter complaints. This is not related to the code changes in this PR and I have not tracked it down. This may be a bit sloppy but I found these bugs in the rainbow_apk side branch and wrote this PR quickly to make sure the fixes get into master.

🙈 Screenshots

Example image
image

Before & after bugfix

image

👯‍♀️ Paired with

"nobody"

n13 commented 1 year ago

Looks like the linter is broken for whatever reason.