fix: QRscan errors on float data; deserialization failed on unaligned data - Githubissues

JoinSEEDS / seeds_light_wallet

http://www.joinseeds.earth/

MIT License

42 stars 22 forks source link

fix: QRscan errors on float data; deserialization failed on unaligned data #1945

Closed chuck-h closed 5 months ago

chuck-h commented 11 months ago

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

Wallet produces corrupted floating point data when scanning a transaction QR

✅ Checklist

[ ] Github issue details are up to date for people to QA.
[ ] I have tested all my changes.

WARNING: I have tested these changes in another repository; however this repo does not build for me (flutter pub version solving failed).

🕵️‍♂️ Notes for Code Reviewer

🙈 Screenshots

Here is an example transaction QR code with floating point field (Weighting) which gives the error

before fix	after fix

Note: this fix is pushed upstream at https://github.com/primes-network/eosdart/pull/46