search

Jojo-Schmitz / MuseScore

MuseScore is a open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
http://musescore.org
Other
31 stars 3 forks source link

Note playback spam when adjusting note pitch using mouse #523

Open PixelDavon opened 1 month ago

PixelDavon commented 1 month ago
  1. Select and hold down a note
  2. Move the note vertically (up or down)
  3. Whenever the cursor moves (horizontally or vertically), the note that is being adjusted is played

In the official Musescore 3.6.2 and Musescore 4.3.2, the note is only played back once (by selecting the note) and there is no playback as the note is being adjusted. I assume this is a new feature in Musescore Evolution, but this seems like a bug

I have not seen an issue about this so Im wondering if my musescore evolution is just bugging out

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 3.7.0.9707330356, revision: GitHub-Jojo-Schmitz-MuseScore-537c0de

https://github.com/Jojo-Schmitz/MuseScore/assets/62317209/fc3ffc61-2dbc-48d6-8af6-cf39ef55a858

Jojo-Schmitz commented 1 month ago

Not sure whether is is a bug of a feature, but when moving a note too low, it crashes, that certainly is a bug

Jojo-Schmitz commented 1 month ago

Ah, it crashes only in Debug builds, in the Q_ASSERT(): https://github.com/Jojo-Schmitz/MuseScore/blob/537c0deb9a1e51f0a0bd76db484c1741ceaf84ac/libmscore/note.cpp#L705-L712 but crashes later (in another Q_ASSERT()) if that one gets commented out. So something to fix here, like doing an early return on an invalid pitch, at least not setting _pitch to an invalid value.

Jojo-Schmitz commented 1 month ago

There's no sound when dragging left/right, in either version, only when dragging up/down The dragging behavoir in 3.7 is better than in 3.6, independantly of the sound 'issue', except for the crash, which I'll fix separately, see #524

I tend to close this issue as not being a bug.