search

Jojo-Schmitz / MuseScore

MuseScore is a open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
http://musescore.org
Other
36 stars 3 forks source link

[Fix] External SMuFL font loading problem with text cursor accessing unacce… #636

Closed worldwideweary closed 2 weeks ago

worldwideweary commented 2 weeks ago

Resolves: #633

Jojo-Schmitz commented 2 weeks ago

@cbjeukendup this is something for your project to allow loading external SMuFL fonts

Jojo-Schmitz commented 1 week ago

Seems to cause the issue from https://musescore.org/en/node/368828 !?!

And indeed reverting it fixes the issue

worldwideweary commented 1 week ago

Ah, gross. I'll check the code again. Wonder how the heck it got Tahoma instead of the main font score...

worldwideweary commented 1 week ago

Might be better to just revert for 3.7, since I don't see the problem here. The appropriate font family is loaded etc, so for it to load some bogus font doesn't make sense to me at all right now... but maybe can make sense of it sometime later

I wonder alternatively if some sort of text cursor update can occur instead around here in order to guard against what I was experiencing (crashes)

Jojo-Schmitz commented 1 week ago

OK, I'll revert it

worldwideweary commented 1 week ago

Apologies for lack of thorough testing

Jojo-Schmitz commented 1 week ago

I'm guilty as charged myself 😉