search

JojoCMS / Jojo-CMS

Jojo is an SEO-friendly, fast, and extensible PHP-based CMS
http://www.jojocms.org/
GNU Lesser General Public License v2.1
20 stars 8 forks source link

Content Cache / CSS Cache bug #13

Closed frankblundt closed 10 years ago

frankblundt commented 11 years ago

With Content Cache turned on, any change to the stylesheets causes the link to style.css to fail for the length of the cache period. If the css caching system (by Rick) could be aware of the content cache system (by Harvey) perhaps it might disable/enable it over that period when a change is detected?

Hambrook commented 11 years ago

I haven't had the issue myself, but does clearing the content cache fix it? We could trigger a clearing of the content cache if the css caching system detects a change within the last <cache period> hours (currently 8).

frankblundt commented 11 years ago

On further investigation... it gets a bit weirder. It's not that the link breaks it's that the cached copy only seems to end up only getting half done (dying just as it gets to the theme css). The browser pulls that version and then holds on to it until you force refresh, whereapon you get the proper full css, until you go to the next page, when it goes back to the half-baked cache version. Maybe the cache version is being copied over before the other parts of the process have finished? I couldn't get the issue to replicate this morning at all but it does it now consistently - maybe because I updated CSSTidy?

Clearing the content cache does fix it - but only until you do a force refresh again at which point it reoccurs.

frankblundt commented 10 years ago

Resolved in 58971b23729265b49aa2d20072a7477b44857525 - the content cache system was returning type text/html on css/styles.css?v=xx when pulling them from the database.