search

JojoCMS / Jojo-CMS

Jojo is an SEO-friendly, fast, and extensible PHP-based CMS
http://www.jojocms.org/
GNU Lesser General Public License v2.1
20 stars 8 forks source link

Comment Form Styles #20

Closed Hambrook closed 11 years ago

Hambrook commented 11 years ago

The comment form has had its class changed to comment-form but the CSS styles are still using .contact-form

Is this intentional as it's odd that this hasn't been caught before now?

frankblundt commented 11 years ago

yes... and that was because.. of something.. oh! validation - the contact form ajax submit script tries to bind itself to anything classed with form.contact-form. It's a poor solution though. What would be better would be to class it (and any others, including contact forms) with something like no-ajax and update the contact js to suit so it leaves them alone. no-validate should probably be an option also.

Hambrook commented 11 years ago

So there's no problem with me updating the CSS styles to match the new class on the form?

frankblundt commented 11 years ago

No - other than it will probably make sense to change them back when I've fixed the underlying issue.

On 24/06/2013, at 5:15 PM, Rick Hambrook notifications@github.com wrote:

So there's no problem with me updating the CSS styles to match the new class on the form?

— Reply to this email directly or view it on GitHub.

frankblundt commented 11 years ago

Form specific classes largely removed (from both Comment and Contact) now and contact js issue resolved (Comment form now set to no-ajax, but still validates using Contact js). We probably need a dependency system.