Visible vertical artifact when "Full-resolution ray marching" is not enabled (using LUTs)

JolifantoBambla / webgpu-sky-atmosphere

A WebGPU implementation of Hillaire's atmosphere model

https://jolifantobambla.github.io/webgpu-sky-atmosphere/

MIT License

10 stars 0 forks source link

Visible vertical artifact when "Full-resolution ray marching" is not enabled (using LUTs) #7

Open alienself opened 3 weeks ago

alienself commented 3 weeks ago

Hi there,

First of all thank you for this project. I have been playing a bit with it and notified a visual artifact right in the middle of the sun's path when using the fast LUT approach. I am using the lastest Chrome on mac (vulkan).

Any way to get rid of it? It looks like a seam issue where the sky view lut is mirrored.

JolifantoBambla commented 3 weeks ago

Oh that's not good. Thanks for reporting! I'm on vacation right now but I'll check it out as soon as I'm back.

I guess it's an issue with how the uvs for the texture lookup are computed - does the sky view lut itself look okay? Is the artifact always there or just for certain angles?

alienself commented 3 weeks ago

Thank you for the quick response!

does the sky view lut itself look okay?

The sky view lut look okay but maybe a single vertical pixel line is black that is not easily visible?

Is the artifact always there or just for certain angles?

It's most noticeable when the sun is positioned away from the zenith. In your demo, no need to move the camera, simply move the sun direction down a bit, toward the horizon and you will see the line appear immediately.