search

Jomelo / LCDMenuLib2

Create a tree menu. Use it with different lcd types / console output / ssh console.
MIT License
249 stars 47 forks source link

control rollover using rotary encoder #21

Closed RawLiquid closed 5 years ago

RawLiquid commented 6 years ago

I disabled the rollover, but I've noticed that going one direction it stops as expected, but going the other direction continues to roll over, making selecting upper values tricky since if you go one too far, your at the bottom again...

Jomelo commented 6 years ago

I have reproduced the problem and upload a bugfix. The menu is not moving to far, but with v1.2.5 i change the display clear handling and forgott to update the cursor position. The bugfix is online (master branch) but i have not created a new version because i will make some tests tomorrow.

RawLiquid commented 6 years ago

No problem, I’m curious to find out where you fixed it as I had started to try and find the issue, and failed. I will admit to not spending much time on it though. Thanks for the quick fix.

On Sat, May 12, 2018 at 4:01 AM Jomelo notifications@github.com wrote:

I have reproduced the problem and upload a bugfix. The menu is not moving to far, but with v1.2.5 i change the display clear handling and forgott to update the cursor position. The bugfix is online (master branch) but i have not created a new version because i will make some tests tomorrow.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Jomelo/LCDMenuLib2/issues/21#issuecomment-388547306, or mute the thread https://github.com/notifications/unsubscribe-auth/AEM5oygR3n-weGRyNgtWfePb6frRFI5tks5txsERgaJpZM4T8PKD .

-- I respectfully decline the invitation to join your hallucination.