Jomik / gnome-wallpaper-changer

GNOME extension to change wallpaper from providers
MIT License
30 stars 7 forks source link

I end up with a blank blue screen sometimes, very quick image cycles, and NSFW setting is not actually available #1

Open komealy opened 7 years ago

komealy commented 7 years ago

Since you are bringing in in wallhaven features, it would be nice if I could provide my login information and be able to leverage everything that the site has to offer (NFSW) for my personal computer. Also when I set the wallpaper to change each minute, it actually cycles through a couple (about three or four) each minute, then finally waits for the next interval. This "cycling" is very quick, and happened every minute (or so).

Every now and then I ended up with a blank blue background, and no image. If there is a way to provide logs or something to help, or contribute myself, I'm more than happy to oblige. I may dig into the code tomorrow or the next day to see if I can come up with anything.

Jomik commented 7 years ago

So, I am currently looking at setting up so that you can login, which will let me implement adding the current wallpaper to favorites, cycling through your favorites, and NSFW. Sadly, it doesn't seem like I am able to query a password from GNOME's keyring.

If you're on the latest commit on master, then there should be a setting to enable "Debugging" under Basic Settings. This will output a lot of information in journalctl /usr/bin/gnome-shell and journalctl /usr/bin/gnome-shell-extension-prefs, append -f to use it as a real time log.

I am trying to figure out why this cycle happens, and also why you end up with a blank background.

I'll be more than happy to take any sort of pull requests, I am still new to coding in JavaScript and GNOME JS.

Jomik commented 7 years ago

Currently I am able to login and save the needed cookies. Now I just need to set up a good password prompt and storage, https://wiki.gnome.org/Projects/Libsecret. The current, https://github.com/Jomik/gnome-wallpaper-changer/commit/820dbdd4577c7545a4c2439c79b476d2a1b499fa#diff-1919e6c4ca625d64f16f81f7f7d8f25aR163, commit is quite a dirty method of doing it, as I was using it for testing.

lachlan-00 commented 7 years ago

setting to wallhaven makes this extension unusable.

It downloaded over 500 wallpapers in a few minutes and slowed down gnome-shell to be unusable.

It also ignored any time settings i set and just continually changed wallpapers before clearing the folder and redownloading a bunch of pictures again.

Jomik commented 7 years ago

@lachlan-00 can you open another issue with this, and also let me know if you got it from extensions.gnome.org or master on this repo?