[Refactor] MlModelGroup should be a component of MlModel

Jon-AtAWS / opensearch-ml-quickstart

This tool kit provides a quickstart for working with OpenSearch and ML models, especially LLMs for vector embeddings to power sementic and semantic sparse search.

Apache License 2.0

2 stars 1 forks source link

[Refactor] MlModelGroup should be a component of MlModel #5

Closed yuye-aws closed 2 days ago

yuye-aws commented 6 days ago

When working on the pull request to fix the model group clean up bug, I found that it would be better to do a little bit refactor, making the MlModelGroup as a component of MlModel. If so, when registering the MlModel, there is a guarantee that model_group_id always exists.

yuye-aws commented 3 days ago

After second thought, only the model group id is needed.

yuye-aws commented 2 days ago

Closing this issue as PR https://github.com/Jon-AtAWS/opensearch-ml-quickstart/pull/4 has been merged.