Update CID file corrected and unused imports

Jon-Becker / nft-generator-py

This tool allows users to generate sets of unique images and metadata using weighted layer collections.

MIT License

304 stars 127 forks source link

Update CID file corrected and unused imports #41

Closed RedHeadphone closed 2 years ago

RedHeadphone commented 2 years ago

Changed update_cid notebook file to python file
removed unused import from update_cid

Jon-Becker commented 2 years ago

I think a notebook is better than python in this case. what is your arguement against it?

RedHeadphone commented 2 years ago

I think a notebook is better than python in this case.

any particular reason?

what is your arguement against it?

since generate script is a python file so update_cid.ipynb should be python file too. So one can update update cid using command prompt. Also few people might not have jupyter/anaconda/others to open python notebook file.

Jon-Becker commented 2 years ago

eh logic makes sense

thanks for contributing