NPM config file - Githubissues

Jon-Biz / FireUser

A Firebase user management module for Angularjs

61 stars 10 forks source link

NPM config file #2

Closed gurdiga closed 10 years ago

gurdiga commented 10 years ago

Added package.json so that one can run npm install and get all the dev environment they need to run tests.
Added the default task as an alias for test:unit.
moved test/karma.unit*.configFile to ./config/.

Jon-Biz commented 10 years ago

Thanks for catching these missing dependencies,

A few things before we merge this pull - I've made comments on the code.

gurdiga commented 10 years ago

Just picket the MIT licence. Are you guys OK with that?

thataustin commented 10 years ago

I checked out the changes and the tests look good locally. I'll leave it to @Jon-Biz to merge when ready.

@gurdiga, thanks for the changes, they look good

Just one note: neither angular nor angularfire keep the karma config in a separate folder. Angular seems to keep them on the root level of the project and angularfire keeps them in the root level of the tests folder. I like the config files closer to the tests, but I'm not going to stand on a mountain on the issue either. Thoughts?

gurdiga commented 10 years ago

Alright! :)