JonBCode / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

Add option to call dsymutil on built binaries #409

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This is useful to run automated test with ASan and/or valgrind on MacOS.
 It's less useful under valgrind which can do this on its own with the proper option, but will do it for every call instead of just once.

Patch has been tested against CDash. Proper symbol output with valgrind (no 
ASan problems reported under CDash but checked locally with specific files)

Feel free to rename the option if doesn't follow some CMake convention (I'm not 
used to CMake yet...)

Original issue reported on code.google.com by m.darb...@gmail.com on 6 Oct 2014 at 9:36

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by m.darb...@gmail.com on 6 Oct 2014 at 9:50

GoogleCodeExporter commented 9 years ago
+cc Mathieu Malaterre

Hi Mathieu (Malaterre), could you validate this patch that add a way to 
generate debug symbols useful for ASan when building on OSX ? As it's a CMake 
issue, I would prefer you handle it. Thanks.

Original comment by antonin on 14 Oct 2014 at 3:05

GoogleCodeExporter commented 9 years ago
patch looks good. I would have prefixed USE_DSYMUTIL with OPJ_ since this is 
very openjpeg specific.

Original comment by mathieu.malaterre on 14 Oct 2014 at 3:10

GoogleCodeExporter commented 9 years ago
Changed patch to prefix with OPJ_

Original comment by m.darb...@gmail.com on 14 Oct 2014 at 4:06

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2903.

Original comment by antonin on 15 Oct 2014 at 10:25