search

JonChong98 / pe

0 stars 0 forks source link

Possible confusing 'all' label in Datastore class diagram #3

Open JonChong98 opened 5 months ago

JonChong98 commented 5 months ago

In the Datastore class diagram in the Developer Guide, there is an association between UniquePersonList and {abstract} Person with an association label all.

image.png

The most immediate explanation inferred is that UniquePersonList contains all {abstract} Person objects. However, on scrolling down a bit and seeing the alternative diagram shown in the Note: An alternative (arguably, more OOP) model... info box, there is no multiplicity or label for that same association. This may cause some confusion on what the all label is supposed to represent.

image.png

Maybe if the explanation above was the intended explanation, the label could be updated to mention it more clearly. This could also be reflected in the diagram in the info box as they would seem to share the same association, as the only change is how Tag is implemented for that diagram.

nus-pe-script commented 5 months ago

Your response not required for this bug as the team has accepted the bug as it is.