JonJala
commented
3 years ago Well, it technically has 3 dimensions already. I guess I could have just had a single "extra_dimension" term to capture that last one, but figured out didn't hurt to just capture a variable amount just in case we ever increase the dimensions for some reason. I suppose if we ever do that, the odds of us not having to make extensive changes in this function anyway are slim, but who knows?
On Wed, May 26, 2021, 5:44 PM ggoldman1 @.***> wrote:
@.**** approved this pull request.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JonJala/mama/pull/18#pullrequestreview-669567726, or unsubscribe https://github.com/notifications/unsubscribe-auth/APIOF53NBTFV74ERA3GXLULTPVTU3ANCNFSM45SWJM4A .
Slightly improved / took care of TODOs for functions dealing with omega and sigma QC
Started trying to create a happy path run_mama_method test (need to finish this one and hopefully add a couple more eventually)
Slight improvements to the run_mama_method to handle modifying the shapes of numpy views better, and to make the setting of M and P more concise