JonMcCullough / HemePure_tools

BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Utils header is missing #2

Open ivan-pi opened 1 year ago

ivan-pi commented 1 year ago
~/compbiomed/HemePure_tools$ find . -name utils.h
~/compbiomed/HemePure_tools$ 
[ 95%] Building CXX object CMakeFiles/voxelizer.dir/voxelizer/source/voxelizer_MultiInput.cpp.o
/Users/di75yas/compbiomed/HemePure_tools/voxelizer/source/voxelizer_MultiInput.cpp:12:10: fatal error: utils.h: No such file or directory
   12 | #include "utils.h"
      |          ^~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/voxelizer.dir/voxelizer/source/voxelizer_MultiInput.cpp.o] Error 1
make[1]: *** [CMakeFiles/voxelizer.dir/all] Error 2
make: *** [all] Error 2
ivan-pi commented 1 year ago

It doesn't seem to be a TIRPC header:

~/Downloads/libtirpc-1.3.3$ find . -name "utils.h"
~/Downloads/libtirpc-1.3.3$ 

I will try to comment it out, and see which symbols are missing then.

ivan-pi commented 1 year ago

If I had to make a guess it would be one of these:

~/compbiomed/HemePure_tools$ find . -name "utils.h"
./build/palabos/externalLibraries/nanoflann/utils.h
./build/palabos/jlabos/src/plbWrapper/utils/utils.h

The jlabos folder is a Java wrapper of Palabos, so it feels kind of irrelevant here.

Okay, judging by this line in the Makefile which calls Scons:

# Path to inlude directories (other than Palabos)
includePaths = ../palabos/externalLibraries/nanoflann

the utils.h is from nanoflann.

ivan-pi commented 1 year ago

It appears like this header is unused in the voxelizer_MultiInput.cpp variant anyways, so the line could be simply deleted. If needed, e.g. in voxelizer.cpp.nanoflann sourcefile, it may be sensible to replace it with:

#include "nanoflann/utils.h"

to have at-least some provenance documented. The Makefile also needs to be adjusted in this case.