search

JonPSmith / AuthPermissions.AspNetCore

This library provides extra authorization and multi-tenant features to an ASP.NET Core application.
https://www.thereformedprogrammer.net/finally-a-library-that-improves-role-authorization-in-asp-net-core/
MIT License
764 stars 155 forks source link

Potential error in Wiki for Setup Authentication #78

Closed roos-robert closed 1 year ago

roos-robert commented 1 year ago

Hi Jon! Thank you for this amazing project and the hard work you are putting into it! I was working on replacing IdentityUser with ApplicationUser in a app using AuthP, checked the wiki for what needed to be changed in my code, over here: https://github.com/JonPSmith/AuthPermissions.AspNetCore/wiki/Setup-Authentication

On point 3 it says the following:

There are some other code used in the examples that only work with UserManager (see below). If you want to use these you need to copy these too:

HostedServiceAddAspNetUsers AspNetUserExtension, specifically ListAllAspNetUsers and CheckAddNewUserAsync

However it seems like ListAllAspNetUsers and HostedServiceAddAspNetUsers are no longer in the project (maybe renamed?). Just thought I'd point it out since this is a feature I'm guessing a lot of people will be/are using to extend the IdentityUser.

Have a great rest of your week! :)

JonPSmith commented 1 year ago

Hi @rr222cy,

Thanks for pointing out this out-of-date documentarian, which I have fixed. When I define the task list for a new version I have to add documentation tasks too, otherwise I won't remember. This one I missed.