Closed Selmirrrrr closed 5 years ago
Hi @Selmirrrrr,
Yes, it looks like I didn't get that quite right. Thanks for pointing this out.
I'm away from my office at the moment but I will have a look at this when I get back next week.
Hi @JonPSmith,
Thanks for you feedback, here's my PR to avoid this issue : #22
Hi @Selmirrrrr,
I'm back from my travels and have fixed this issue. There is a new version, 2.0.1, of EfCore.TestSupport which contains this fix.
Thanks for pointing this out and providing a PR. I used your pull request, but improved it a bit. If you don't provide the calling assembly it defaults to Assembly.GetCallingAssembly()
, which is how the other versions work too.
Great, thank you very much 👍
Hi,
Firstly thank you very much for this useful lib, it'll help us a lot.
I'm facing an issue when calling creating seed data with
Assembly.GetCallingAssembly()).Location
, when referencing the project from NuGet.org theAssembly.GetCallingAssembly()).Location
points toC:\Users\username\.nuget\packages\efcore.testsupport\2.0.0\lib\netstandard2.0\TestSupport.dll
and TestSupport was unable to find\bin\
part in it and threw an exception.Everything works fine when I reference directly your project in my solution.
My setup
The issue is present with built-in Visual Studio's test runner and with
dotnet test
, didn't tested with others.To Reproduce
Expected behavior
A seed JSON file is created in current test's folder
Current behavior
An exception is thrown.
I saw that issues #4 and #14 face the same issue that should have been fixed since then but it seems it's still here...
I'll send you a PR to try to provide a way to avoid this issue in the future.