search

JonPSmith / EfCore.TestSupport

Tools for helping in unit testing applications that use Entity Framework Core
https://www.thereformedprogrammer.net/new-features-for-unit-testing-your-entity-framework-core-5-code/
Other
352 stars 53 forks source link

enhanced the database-model comparison with optional parameters for schemas and tables #35

Closed alexander-malyshkin closed 4 years ago

JonPSmith commented 4 years ago

Hi @alexander-malyshkin,

I'm not going to accept your pull request because you are adding to the signature of the EfSchemeCompare feature. If you let me know why you want this feature and I think it is generally useful I may achieve this another way.

Generally it's always good to raise a issue first before you do a pull request. The author of a library normally has a better overview of the features and can discuss the different ways you could achieve it. Also remember the author has to support any feature you add, and that can be a burden.

alexander-malyshkin commented 4 years ago

Hi Jon,

Thank you for providing me with the feedback! My goal was to introduce the functionality for working with specific database schemas and tables. The class CompareEfSql has a method GetDatabaseModelViaScaffolder(DbContext[] contexts, string connectionString, IDesignTimeServices designTimeService)

It invokes the constructor for DatabaseModelFactoryOptions the following way: new DatabaseModelFactoryOptions(new string[] { }, new string[] { })

I would like to enhance this with specifying schemas and tables explicitly. This is what my pull request is about. If you believe my proposed changes are not suitable, I understand. I would appreciate it if you considered making changes to your code base that would allow comparing specific schemas

Regards, Alexander Malyshkin.

On May 10, 2020 at 11:18, Jon P Smith notifications@github.com wrote:

Hi @alexander-malyshkin https://github.com/alexander-malyshkin,

I'm not going to accept your pull request because you are adding to the signature of the EfSchemeCompare feature. If you let me know why you want this feature and I think it is generally useful I may achieve this another way.

Generally it's always good to raise a issue first before you do a pull request. The author of a library normally has a better overview of the features and can discuss the different ways you could achieve it. Also remember the author has to support any feature you add, and that can be a burden.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JonPSmith/EfCore.TestSupport/pull/35#issuecomment-626291086, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOVIQD3YYPZTGVOJGN7NP3RQZPMXANCNFSM4M4YOOZQ .

JonPSmith commented 4 years ago

Hi @ alexander-malyshkin,

Are you aware of the CompareEfSql config options? That allows you to select what schema+tables you want to ignore. This usually handles most situations.