JonPSmith / GenericServices

GenericServices helps with building a service/application layer in a .NET based application using EF6.x
MIT License
247 stars 44 forks source link

Breaking changes in EF Core 3 #20

Open MarcoGaribaldi opened 5 years ago

MarcoGaribaldi commented 5 years ago

Hi!

I have been trying to use GenericServices with EF Core 3 but there are breaking changes which make GenericServices incompatible. First issue I have found is that IEntityType.IsQueryType is no longer available in EF Core 3. There may be additional issues I have not found yet. You may want to take a look at this page for a list of changes:

https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-3.0/breaking-changes

JonPSmith commented 5 years ago

Hi @MarcoGaribaldi,

I was pretty sure there would be breaking changes with EF Core 3. I'm quite busy at the moment so I don't plan to update GenericServices (or my other libs) until later. Maybe until its released.

JonPSmith commented 5 years ago

Hi @MarcoGaribaldi ,

I'll keep this open as it reminds me of one of the changes I need to do for NET Core 3.

MarcoGaribaldi commented 5 years ago

Sure, makes sense. Sorry for stepping in.