search

JonShort / npm-bumpall

Utility to bump all packages to latest
MIT License
0 stars 0 forks source link

Enhancement - Replace CLI code with Clap cargo #18

Closed jaysc closed 1 year ago

jaysc commented 1 year ago

Relates to #17

Initial replacement of our CLI with clap.

JonShort commented 1 year ago

Pulled this down - seems to work well - I kinda expected it to remove a lot more code our side though, it's almost comparable

Does make future changes easier though so I'm open to the change

jaysc commented 1 year ago

I accidently included cmd.rs which was my replace file as I was working through out. It's been removed now.

I think it's great that it just handles all the arg parsing. We don't have to deal with the split and check the tag anymore. Also the help autogen with doc comments is nicely formatted.

There may be more we could do.

JonShort commented 1 year ago

Seems decent, think we should add - make it ready for review when happy with it