search

JonahBrooks / poppr

Note: This is an old fork. For complete project see grunwaldlab/poppr. -- Most of the C code (and their R wrappers) was written by me.
http://www.github.com/grunwaldlab/poppr
0 stars 0 forks source link

Minimum Spanning Networks with single population issues #3

Open zkamvar opened 10 years ago

zkamvar commented 10 years ago

Two issues with single population minimum spanning networks from poppr.msn:

  1. showplot argument is not passed on to singlepop_msn internal function.
  2. The filtered and clone corrected distance matrix is passed, but the filtered and clone corrected genclone object is not passed.
zkamvar commented 9 years ago

The previous issues were fixed with DRY code, which improved the logic, but now it still has issues with single populations and is noted in these lines.

In addition, should the filtering step come before everything is sent off to singlepop_msn()? Should the function be rewritten?