JonahPlusPlus / bevy_atmosphere

A procedural sky plugin for bevy
Apache License 2.0
267 stars 19 forks source link

[need help] bevy 0.11 support #53

Closed rlidwka closed 1 year ago

rlidwka commented 1 year ago

In this PR there are obvious changes. I made them, so you don't have to.

The problem: macros subcrate depends on syn 1, but bevy updated to syn 2.

Anyone here knows proc macros? Can you update macro folder, pretty please?

robtfm commented 1 year ago

i made a pr on your branch. it's actually fine for this crate to use syn 1.0, we just need to update the path of the AppTypeRegistry as per the migration guide. i also changed a few other things.

note that you'll need to patch bevy_spectator as well if that's not been updated already:

[patch.crates-io]
bevy_spectator = { git="https://github.com/GodGotzi/bevy_spectator" }
VirxEC commented 1 year ago

I tested this PR in my app, and it works perfectly!

Shatur commented 1 year ago

Superseded by #54.