search

JonahPlusPlus / bevy_atmosphere

A procedural sky plugin for bevy
Apache License 2.0
267 stars 19 forks source link

Sky doesn't work #64

Closed VirxEC closed 11 months ago

VirxEC commented 11 months ago

When I updated to the new 0.8 version, I get the error ERROR bevy_asset::server: path not found: bevy_atmosphere/shaders/skybox.wgsl Which is weird because this plugin used to work when I was testing it earlier on the PR fork and I dropped a comment saying that it worked fine.

Shatur commented 11 months ago

Interesting, looks like it works locally (examples still work!), but doesn't work if it's a separate crate. @sphw maybe you know what could cause it?

sphw commented 11 months ago

My best guess is this is something to do with a bug with embedded_asset and publish crates / libraries. Not exactly sure what. IMO given all the strangeness and bugs with embedded_asset it might make sense to revert the commit that makes that change from my PR, and wait until it stabilizes further.

Shatur commented 11 months ago

Agree, could you please open a PR that reverts to the previous approach?

Shatur commented 11 months ago

Fixed by #65.