search

JonasCz / save-for-offline

Android app for saving webpages for offline reading.
GNU General Public License v2.0
140 stars 45 forks source link

Feature suggestion: Save to a custom directory, and save as Epub. #12

Closed nutpantz closed 8 years ago

nutpantz commented 9 years ago

I would love a way to save the downloaded web page to a custom directory. Would be great if the directory that the pages is saved in is similar to the web page title. A save as epub option would be a life saver ( its format is based on HTML, and it's an open source format)

Thank you for all your work.

JonasCz commented 9 years ago

Svimg to a custom directory is coming ! Right now, pages are saved in /sdcard/Android/data/Jonas.tool.saveforoffline/ .

I'll look into epub.

nutpantz commented 9 years ago

Fantastic, I will report back with any issues I find. Thank you for your effort.

JonasCz commented 9 years ago

This is now implemented, and it seems to work for me. Let me know if something does not work. Also note that the Play Store version is outdated and broken, so you'll have to download the APK from the releases section or compile it yourself. More fixes and improvements coming !

nutpantz commented 9 years ago

When I tried downloading a page from wikipedia (en.m.wikipedia.org/wiki/Dominoes) It force closes, but stays in the notification bar saying it's saving web page. When i try to cancel it force closes again and force closes again when I try to cancel and stays in notification bar. I have to forcestop from app info. However it seems to download the webpage just fine but can't finish or close off properly. but I did get it to download a different page just fine.

I get most of my stuff from fdroid.

JonasCz commented 9 years ago

This should be fixed now. Let me know if it crashes on any other websites. More fixes coming.

nutpantz commented 9 years ago

Another web page failed, however it still downloaded the text which was the important partforum.xda-developers.com/galaxy-s3/help/luks-manager-mounts-volumes-root-t2662737 I don't mind that it fails from time to time, but it not closing or canceling with out forcing it is a pain Than you for all your hard work

JonasCz commented 9 years ago

Fixed now, cancelling should be also fixed now.

nutpantz commented 9 years ago

Tried downing a few pages, found a few that hung at downloading page, never saw the cancel download option in the status bar notification at all now. Lost the page links sorry.

JonasCz commented 9 years ago

I cannot reproduce this, can you post some links to repro this ? The cancel option should always be there though.

nutpantz commented 9 years ago

I just installed an ad blocker host file, and since your app is 5x faster and not one site has failed to copy. I'll keep testing and update if I find anything. But when it's downloading a site there is no cancel in the notification bar. Just saving site

JonasCz commented 8 years ago

This is now implemented, you can choose where to save the files in the preferences.

Saving as Epub is probably not possible at the moment.