JonasCz / save-for-offline

Android app for saving webpages for offline reading.
GNU General Public License v2.0
139 stars 45 forks source link

Use a listview instead of gridlayout for smaller devce. #7

Closed axkr closed 9 years ago

axkr commented 9 years ago

Please use a listview instead of a gridlayout for at least screen classes "small" and "normal":

public String sizeClassificationText( Context ctx ) {
switch ( mSizeClass ) {
case Configuration.SCREENLAYOUT_SIZE_SMALL:
return "small";
case Configuration.SCREENLAYOUT_SIZE_NORMAL:
return "normal";
case Configuration.SCREENLAYOUT_SIZE_LARGE:
return "large";
case Configuration.SCREENLAYOUT_SIZE_XLARGE:
return "xlarge";
case Configuration.SCREENLAYOUT_SIZE_UNDEFINED:
return ctx.getString(R.string.undefined);
}
return ctx.getString(R.string.unknown);
}
JonasCz commented 9 years ago

Wired, I thought I was doing this already. Will look into it.

axkr commented 9 years ago

Ok it may already be a listview? But this list view doesn't use the available space optimal. Only 4 list entries are displayed on a screen of height 640dp in portrait mode. The titles of these items are displayed in the upper right corner? The size of the text would have allowed 7 lines of text to display in one list item?

Screen values are determined with Android ScreenInfo: https://play.google.com/store/apps/details?id=com.jotabout.screeninfo

JonasCz commented 9 years ago

Post screenshot, because it works perfectly for me. Also , in case you don't know, there is an option in settings to change it.

JonasCz commented 9 years ago

Also, there is an option in settings to change it, in case you didn't know. If you want to put as many items as possible, there is an option for small list without thumbnails.

axkr commented 9 years ago

Ok "List no thumbnails" is the best option for me. You can close this item.

JonasCz commented 9 years ago

Are the thumbnails not showing with any of the other options? That would be bad...

JonasCz commented 9 years ago

Closing for now as no message back, I can assume this is fixed. Let me know if it isn't.