JonasDev17 / qb-garages

GNU General Public License v3.0
98 stars 70 forks source link

Police Garage Issue #14

Closed jokernights closed 2 years ago

jokernights commented 2 years ago

I just downloaded this and love how it works. but i am not sure if i am doing something wrong or how it works. With the other one i already had police vehicles set but no matter where i go i can't pull out the police vehicles, same with ambulance? This is in policejob/config.lua image image

These are in ambulancejob/config.lua image image

but when i do the radial menu and open garage it says no vehicles stored? is there a special way to get emergency vehicles out with proper grade?

JonasDev17 commented 2 years ago

This garage script allows only owned cars to be stored or retreived. It is not a replacement for the vehicle spawner included with qb-policejob.

jokernights commented 2 years ago

This garage script allows only owned cars to be stored or retreived. It is not a replacement for the vehicle spawner included with qb-policejob.

So is there a way to have the best of both worlds? Or do I have to put the original garages back?

JonasDev17 commented 2 years ago

For now, I would use the qb-policejob spawner but I am planning on adding this functionality as it is frequently requested.

jokernights commented 2 years ago

For now, I would use the qb-policejob spawner but I am planning on adding this functionality as it is frequently requested.

Is this a seperate script? Because it was working with original garages. So would I look for policjob spawner or does that mean I have to go back to original garages?

JonasDev17 commented 2 years ago

No, you can keep this garages script, but in qb-policejob there is a location defined where you can get and return policecars. Use that

jokernights commented 2 years ago

No, you can keep this garages script, but in qb-policejob there is a location defined where you can get and return policecars. Use that

Is that different then what code I sent in the original menu?

JonasDev17 commented 2 years ago

I am not sure, where did you get that code anyway? it is not from my script

jokernights commented 2 years ago

I am not sure, where did you get that code anyway? it is not from my script

No that is the config in policejob that is where they spawned with the original garages in place. Now when I go to that spot the new garages pulls ups but. Says there is nothing in the garage .. because I believe the garage and policjob worked hand in hand .. so the cars that are assigned are no longer there with the new garages

JonasDev17 commented 2 years ago

No, qb-policejob never worked together with qb-garages - they are two different scripts, always have been. You are probably in the wrong location if the option doesn't show up.

jokernights commented 2 years ago

No, qb-policejob never worked together with qb-garages - they are two different scripts, always have been. You are probably in the wrong location if the option doesn't show up.

Nope I’m in the position that the original spawn location was that I set and when I had original garages it allowed me to pull out police vehicles and ambulances now it doesn’t give me that option

jokernights commented 2 years ago

No, qb-policejob never worked together with qb-garages - they are two different scripts, always have been. You are probably in the wrong location if the option doesn't show up.

Nope I’m in the position that the original spawn location was that I set and when I had original garages it allowed me to pull out police vehicles and ambulances now it doesn’t give me that option

It literally said police garage with the old one and used the same garage that all the other cars did but it was set to pull vehicles out per rank of officer but with new garage it doesn’t pull anything out so I’m sure they somewhat work together ??

JonasDev17 commented 2 years ago

Ok, let me have a look.

JonasDev17 commented 2 years ago

https://github.com/qbcore-framework/qb-policejob/blob/86930ece3f80d095e34906ec275900808e53eac2/client/job.lua#L149 https://github.com/qbcore-framework/qb-policejob/blob/86930ece3f80d095e34906ec275900808e53eac2/client/job.lua#L191 https://github.com/qbcore-framework/qb-policejob/blob/86930ece3f80d095e34906ec275900808e53eac2/client/job.lua#L205

JonasDev17 commented 2 years ago

Its all in qb-policejob, not related to qb-garages

jokernights commented 2 years ago

Ok, let me have a look.

All I did was remove qb garages and installed yours I didn’t break anything and it didn’t work the way it was originally setup

JonasDev17 commented 2 years ago

Remove the PD Garage (the one in my garage script) at that location and see if it fixes it.

JonasDev17 commented 2 years ago

Join my discord so we can continue there https://discord.gg/ZcrxXcqvJj

jokernights commented 2 years ago

Join my discord so we can continue there https://discord.gg/ZcrxXcqvJj

Ok I will when I get home

jokernights commented 2 years ago

Join my discord so we can continue there https://discord.gg/ZcrxXcqvJj

Hey thank you so much. I --[[ commented out all the police and pdgarages and it worked .. so the normal garages work and the PD and ambulance work now! .. you said in the future you may add this option in ?

JonasDev17 commented 2 years ago

Yes

jokernights commented 2 years ago

Yes image another question.. so i am testing house garages? is this not in yet? it says vehicle cannot be stored

JonasDev17 commented 2 years ago

House garages should work, do you own the car? Otherwise I will have another look, might have broken parking for qb-houses by enabling support for loaf housing

JonasDev17 commented 2 years ago

Could you make another issue so I can close this one? Just so I see what needs fixing without having to read the convos again.

jokernights commented 2 years ago

Could you make another issue so I can close this one? Just so I see what needs fixing without having to read the convos again.

Yes you can close this one. I will make sure loaf housing is off first then make a ticket if needed

JonasDev17 commented 2 years ago

What I meant to say is that I may have broken the script by adding loaf housing but yes, make sure that it's set to false.