JonasDev17 / qb-garages

GNU General Public License v3.0
98 stars 70 forks source link

Updated server side to check for keys and house ownership #85

Closed SlimChances closed 1 year ago

OfficialRDB commented 1 year ago

I'm still able to pull people their cars out of their garage and parking add my own house says: vehicle can't be stored. Or it doesn't not let you pull the car at all.

flash061 commented 1 year ago

Yeah that didn't fix it, I can still take other peoples cars out of their home garages

SlimChances commented 1 year ago

dang well im trying lol

OfficialRDB commented 1 year ago

dang well im trying lol

I know you are. Thank you for that. I would love it see that people can only see their own car in a garage even if they have keys. That also would be for the gang parking ect...

The problem could be the local hasHouseKey = exports['qb-houses']:hasKey(result[1].license, result[1].citizenid, house)

house is not being used in the callback, Maybe if we change this to garage ? Looks like that fixed the issue for me.

local hasHouseKey = exports['qb-houses']:hasKey(result[1].license, result[1].citizenid, garage)

SlimChances commented 1 year ago

Okay so i updated my version and some stuff there and tested and it is working now.

JonasDev17 commented 1 year ago

This should no longer be needed. The zone is only created if a player has a key to the house therefore a key check should not be necessary.